Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license hf 0710 #7989

Merged
merged 8 commits into from
Aug 19, 2023
Merged

Fix license hf 0710 #7989

merged 8 commits into from
Aug 19, 2023

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #7968

Problem Summary:

The license header should be "PingCAP, Inc" instead of "PingCAP, Ltd"

What is changed and how it works?

Fix the license by using the script in https://github.com/JaySon-Huang/licenseheaders/tree/my_fork, then format the code by .clang-format

gh repo clone JaySon-Huang/licenseheaders
./fix_license.sh /path/to/tiflash
cd /path/to/tiflash
python3 format-diff.py --diff_from `git merge-base upstream/master  HEAD`

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2023
@JaySon-Huang JaySon-Huang mentioned this pull request Aug 19, 2023
Closed
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-19 03:34:01.434645083 +0000 UTC m=+947605.983661070: ☑️ agreed by hongyunyan.
  • 2023-08-19 03:41:19.647437179 +0000 UTC m=+948044.196453166: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 7a53de7 into pingcap:release-6.5-20230710-v6.5.2 Aug 19, 2023
@JaySon-Huang JaySon-Huang deleted the fix_license_hf_0710 branch August 19, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @hongyunyan @Lloyd-Pottiger